Shirley Temple as Priscilla 'Winkie' Williams

Victor McLaglen as Sgt. Donald MacDuff

C. Aubrey Smith as Colonel Williams

June Lang as Joyce Williams

Michael Whalen as Lt. Brandes aka 'Coppy'

Cesar Romero as Khoda Khan

Constance Collier as Mrs. Allardyce

Douglas Scott as Mott

Gavin Muir as Capt. Bibberbeigh

Willie Fung as Mohammet Dihn

Brandon Hurst as Bagby

Lionel Pape as Major Allardyce

Clyde Cook as Pipe Major Sneath

Bunny Beatty as Elsie Allardyce

Lionel Braham as Maj. Gen. Hammond

Mary Forbes as Mrs. MacMonachie

Cyril McLaglen as Cpl. Tummel

Pat Somerset as Officer

Hector V. Sarno as Driver

George Ford as Soldier (uncredited)